[Asterisk-code-review] res_pjsip_messaging: Allow setting domain of recipient (asterisk[18])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/15597 )

Change subject: res_pjsip_messaging: Allow setting domain of recipient
......................................................................


Patch Set 2: Code-Review-1

(2 comments)

https://gerrit.asterisk.org/c/asterisk/+/15597/2//COMMIT_MSG 
Commit Message:

https://gerrit.asterisk.org/c/asterisk/+/15597/2//COMMIT_MSG@15 
PS2, Line 15: This is a slight rework of a modification to my original patch for this
            : issue that was contributed to my open issue on this matter in
            : https://issues.asterisk.org/jira/browse/ASTERISK-28513.
Actually, this paragraph is not even needed as it is off topic.  The commit message is supposed to describe the patch as it actually is and not necessarily to give the history of the patch.  This version of the patch is what will ultimately get merged into the code base.  It is irrelevant to describe a different patch attached to the issue.


https://gerrit.asterisk.org/c/asterisk/+/15597/2/res/res_pjsip_messaging.c 
File res/res_pjsip_messaging.c:

https://gerrit.asterisk.org/c/asterisk/+/15597/2/res/res_pjsip_messaging.c@242 
PS2, Line 242: 	char *domain = strchr(to, '@');
Yep, C does not allow declaring variables in the middle of a code block.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/15597
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 18
Gerrit-Change-Id: I26fb8605d7cb200332a0442879fd9a5679a65022
Gerrit-Change-Number: 15597
Gerrit-PatchSet: 2
Gerrit-Owner: Brian J. Murrell <brian at interlinx.bc.ca>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-CC: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Tue, 09 Mar 2021 16:37:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210309/4bec0f3b/attachment.html>