[Asterisk-code-review] res_pjsip_messaging: Allow setting domain of recipient (asterisk[18])

Richard Mudgett asteriskteam at digium.com
Tue Mar 9 10:00:14 CST 2021


Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/15597 )

Change subject: res_pjsip_messaging: Allow setting domain of recipient
......................................................................


Patch Set 1: Code-Review-1

(2 comments)

https://gerrit.asterisk.org/c/asterisk/+/15597/1//COMMIT_MSG 
Commit Message:

https://gerrit.asterisk.org/c/asterisk/+/15597/1//COMMIT_MSG@15 
PS1, Line 15: This is a slight rework of a modification to my to my original patch
Duplicated words
s/to my to my/to my/


https://gerrit.asterisk.org/c/asterisk/+/15597/1//COMMIT_MSG@17 
PS1, Line 17: https://issues.asterisk.org/jira/browse/ASTERISK-28513.
Referencing other issues should be done this way:
ASTERISK_28513 or ASTERISK~28513

The gerrit plug-in that creates hotlinks in the message and automatically closes issues when the patch is merged is not very smart.  It acts on ALL references unless you alter them to not be recognized.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/15597
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 18
Gerrit-Change-Id: I26fb8605d7cb200332a0442879fd9a5679a65022
Gerrit-Change-Number: 15597
Gerrit-PatchSet: 1
Gerrit-Owner: Brian J. Murrell <brian at interlinx.bc.ca>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-CC: Friendly Automation
Gerrit-Comment-Date: Tue, 09 Mar 2021 16:00:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210309/c080e637/attachment.html>


More information about the asterisk-code-review mailing list