[Asterisk-code-review] func_frame_drop: New function (asterisk[master])

[N A]

Attention is currently required from: Joshua Colp.
N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16071 )

Change subject: func_frame_drop: New function
......................................................................


Patch Set 7:

(1 comment)

File funcs/func_framedrop.c:

https://gerrit.asterisk.org/c/asterisk/+/16071/comment/93bf08d6_0830d62d 
PS2, Line 67: 					<enum name = "HANGUP" />
> Is that documented anywhere? Should it be documented the consequences of such stuff?
Yeah, here: https://wiki.asterisk.org/wiki/display/AST/Early+Media+and+the+Progress+Application
It's also pretty basic knowledge that calls should be Progress()'d or Answer()'d (if it's not implicitly done), but there is no requirement calls need to be answered (and sometimes, that's expressly undesired behavior).
I'm inclined to think if somebody is intentionally dropping answer frames, he knows perfectly well what he's doing, but I can add a note in the usage if that would help.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16071
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I8147c9d55d74e2e48861edba6b22f930920541ec
Gerrit-Change-Number: 16071
Gerrit-PatchSet: 7
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at sangoma.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Mon, 28 Jun 2021 13:28:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Comment-In-Reply-To: N A <mail at interlinked.x10host.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210628/7a988e1d/attachment-0001.html>