[Asterisk-code-review] app_dial: Expanded A option to add caller announcement (asterisk[16])

[George Joseph]

Attention is currently required from: Joshua Colp, N A.
George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/15926 )

Change subject: app_dial: Expanded A option to add caller announcement
......................................................................


Patch Set 5: Code-Review+2

(6 comments)

File apps/app_dial.c:

https://gerrit.asterisk.org/c/asterisk/+/15926/comment/268a4821_ae1afc18 
PS1, Line 2986: 				
> Whitespace
Done


https://gerrit.asterisk.org/c/asterisk/+/15926/comment/ee8e9a8c_bac5a3a0 
PS1, Line 2989: 				
> Whitespace
Done


File apps/app_dial.c:

https://gerrit.asterisk.org/c/asterisk/+/15926/comment/0a25668a_4e26e6c0 
PS2, Line 2989: 				
> Still have whitespace here.
Done


File apps/app_dial.c:

https://gerrit.asterisk.org/c/asterisk/+/15926/comment/1a491830_2406949c 
PS3, Line 2965: 				int ms, ms2;
> These should be renamed to be clearer about which is for what
Done


https://gerrit.asterisk.org/c/asterisk/+/15926/comment/a9926090_dcc14eb4 
PS3, Line 2993: 				active_chan = ast_waitfor_n(chans, 2, &ms);
> ms2 isn't actually used for scheduling or anything, it should be (that is: if ms2 is wanting things  […]
Done


File apps/app_dial.c:

https://gerrit.asterisk.org/c/asterisk/+/15926/comment/8b33316d_1f5e5768 
PS4, Line 2993: 				active_chan_peer = ast_waitfor_n(chans, 2, &mspeer);
> You can't do this. […]
Done



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/15926
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: If6eed3ff5c341dc8c588c8210987f2571e891e5e
Gerrit-Change-Number: 15926
Gerrit-PatchSet: 5
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Comment-Date: Wed, 23 Jun 2021 13:47:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Comment-In-Reply-To: George Joseph <gjoseph at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210623/523d3b84/attachment.html>