[Asterisk-code-review] func_frame_drop: New function (asterisk[master])

[George Joseph]

Attention is currently required from: N A, Joshua Colp.
George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16071 )

Change subject: func_frame_drop: New function
......................................................................


Patch Set 6: Code-Review+1

(4 comments)

Patchset:

PS6: 
Go ahead and cherry pick to 16 and 18.


File funcs/func_frame_drop.c:

https://gerrit.asterisk.org/c/asterisk/+/16071/comment/74b22ddc_3118f638 
PS5, Line 284: 		if (strcasecmp(value, frametype2str[i].str) == 0) {
> These now have to be changed to strcasestr(buffer, frametype2str[i]. […]
Done


https://gerrit.asterisk.org/c/asterisk/+/16071/comment/5b1bad2e_b9dbf0a8 
PS5, Line 290: 		if (strcasecmp(value, controlframetype2str[i].str) == 0) {
> same.
Done


File funcs/func_framedrop.c:

https://gerrit.asterisk.org/c/asterisk/+/16071/comment/20c4d904_2295fe4a 
PS2, Line 45: ilter list type
> How about "direction"?
Done



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16071
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I8147c9d55d74e2e48861edba6b22f930920541ec
Gerrit-Change-Number: 16071
Gerrit-PatchSet: 6
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Wed, 23 Jun 2021 12:47:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: George Joseph <gjoseph at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210623/fcf23173/attachment.html>