[Asterisk-code-review] core: Don't play silence for Busy() and Congestion() applications. (asterisk[16])

[Joshua Colp]

Attention is currently required from: George Joseph.
Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16074 )

Change subject: core: Don't play silence for Busy() and Congestion() applications.
......................................................................


Patch Set 1:

(1 comment)

Patchset:

PS1: 
> Think there are any ramifications to changing the default behavior of wait_for_hangup to not send si […]
The function is internal and only used by the Busy() and Congestion() dialplan applications. I've run through things with those, and haven't encountered an issue changing this. I believe that the silence was merely a side effect of using ast_safe_sleep and not a required implementation detail of the applications.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16074
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I066bfc987a3ad6f0ccc88e0af4cd63f6a4729133
Gerrit-Change-Number: 16074
Gerrit-PatchSet: 1
Gerrit-Owner: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-CC: George Joseph <gjoseph at digium.com>
Gerrit-Attention: George Joseph <gjoseph at digium.com>
Gerrit-Comment-Date: Mon, 21 Jun 2021 13:14:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: George Joseph <gjoseph at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210621/35767621/attachment.html>