[Asterisk-code-review] res_pjsip/pjsip_message_filter: set preferred transport in pjsip_mess... (asterisk[16])

[Bernd Zobl]

Attention is currently required from: Florian Floimair, Joshua Colp, George Joseph.
Bernd Zobl has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/15630 )

Change subject: res_pjsip/pjsip_message_filter: set preferred transport in pjsip_message_filter
......................................................................


Patch Set 5: Code-Review+1

(1 comment)

File res/res_pjsip/pjsip_message_filter.c:

https://gerrit.asterisk.org/c/asterisk/+/15630/comment/e034b107_f88df2ee 
PS5, Line 242: if ((tdata->tp_info.transport->key.type != PJSIP_TRANSPORT_UDP) &&
             : 		(tdata->tp_info.transport->key.type != PJSIP_TRANSPORT_UDP6)) {
             : 		sel.type = PJSIP_TPSELECTOR_LISTENER;
             : 		sel.u.listener = tdata->tp_info.transport->factory;
             : 		prm.tp_sel = &sel;
             : 	}
> 3 is dependent on the underlying configuration, fyi. If rewrite_contact is set to "yes" then it is the source IP address and port. If set to "no" then it is the Contact as provided in the REGISTER request.

good to know, thanks.

I'll consider the comment as resolved then?



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/15630
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I598e60257a7f92b29efce1fb3e9a2fc06f1439b6
Gerrit-Change-Number: 15630
Gerrit-PatchSet: 5
Gerrit-Owner: Florian Floimair <f.floimair at commend.com>
Gerrit-Reviewer: Bernd Zobl <b.zobl at commend.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Florian Floimair <f.floimair at commend.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: George Joseph <gjoseph at digium.com>
Gerrit-Comment-Date: Tue, 15 Jun 2021 12:17:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Comment-In-Reply-To: Bernd Zobl <b.zobl at commend.com>
Comment-In-Reply-To: George Joseph <gjoseph at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210615/edb51495/attachment.html>