[Asterisk-code-review] app_waitforcond: New application (asterisk[16])

[Joshua Colp]

Attention is currently required from: N A, Richard Mudgett.
Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/15928 )

Change subject: app_waitforcond: New application
......................................................................


Patch Set 7: Code-Review-1

(2 comments)

File apps/app_waitforcond.c:

https://gerrit.asterisk.org/c/asterisk/+/15928/comment/01cb7430_a457bcd1 
PS7, Line 210: 		pbx_substitute_variables_helper(chan, expr, condition, sizeof(condition) - 1);
Looking at pbx_substitute_variables_helper I don't think you need the "expr = ast_strdupa(expression);" either. You can just pass in expression to it.


https://gerrit.asterisk.org/c/asterisk/+/15928/comment/e97e8116_e8d6674b 
PS7, Line 237: AST_MODULE_INFO_STANDARD(ASTERISK_GPL_KEY, "Wait until condition is true");
This needs to use AST_MODULE_INFO_STANDARD_EXTENDED to be marked as extended support.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/15928
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I08adf2824b8bc63405778cf355963b5005612f41
Gerrit-Change-Number: 15928
Gerrit-PatchSet: 7
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Attention: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Tue, 15 Jun 2021 10:13:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210615/9604fefe/attachment.html>