[Asterisk-code-review] app_dial: Expanded A option to add caller announcement (asterisk[master])

Mark Murawski asteriskteam at digium.com
Fri Jun 11 13:20:22 CDT 2021


Attention is currently required from: N A.
Mark Murawski has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/15941 )

Change subject: app_dial: Expanded A option to add caller announcement
......................................................................


Patch Set 5:

(1 comment)

Patchset:

PS5: 
> The A option currently plays audio to the callee on pickup as it is. […]
Fair enough, taking advantage of the existing option and adding more more param isn't the end of the world.... it just winds up being a slippery slope of feature creep that could otherwise be handled in 'userspace' by dialplan and other options.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/15941
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: If6eed3ff5c341dc8c588c8210987f2571e891e5e
Gerrit-Change-Number: 15941
Gerrit-PatchSet: 5
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Mark Murawski <markm at intellasoft.net>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Comment-Date: Fri, 11 Jun 2021 18:20:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: N A <mail at interlinked.x10host.com>
Comment-In-Reply-To: Mark Murawski <markm at intellasoft.net>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210611/52cec121/attachment.html>


More information about the asterisk-code-review mailing list