[Asterisk-code-review] app_dial: Expanded A option to add caller announcement (asterisk[master])

[Mark Murawski]

Attention is currently required from: N A.
Mark Murawski has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/15941 )

Change subject: app_dial: Expanded A option to add caller announcement
......................................................................


Patch Set 5:

(1 comment)

Patchset:

PS5: 
> It isn't a new option, it's just expanding the existing one to make it more flexible, like how the D […]
Pickup Macros, ie: the 'U' option to dial are alive and well.  In modern Asterisk, internally they use GoSub, but they have been classically referred to as 'pickup macros'.  Which is, dialplan code that runs when the callee channel picks up.  This can be used (and I use this) to play audio to the callee upon pickup.

More generically, well right it's not a new-new option per say in terms of a new letter-option, but it's adding additional parameter based functionality to Dial()... but is it entirely necessary?



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/15941
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: If6eed3ff5c341dc8c588c8210987f2571e891e5e
Gerrit-Change-Number: 15941
Gerrit-PatchSet: 5
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Mark Murawski <markm at intellasoft.net>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Comment-Date: Fri, 11 Jun 2021 14:23:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: N A <mail at interlinked.x10host.com>
Comment-In-Reply-To: Mark Murawski <markm at intellasoft.net>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210611/c9c2e936/attachment-0001.html>