[Asterisk-code-review] Take the transfer target off hold when handling INVITE-with-Replaces. (asterisk[16])

Sean Bright asteriskteam at digium.com
Fri Jun 11 08:44:46 CDT 2021


Attention is currently required from: Joshua Colp, Ben Smithurst.
Sean Bright has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16042 )

Change subject: Take the transfer target off hold when handling INVITE-with-Replaces.
......................................................................


Patch Set 2:

(1 comment)

Patchset:

PS2: 
> As far as I can tell the longest line is 70 characters so it appears to comply with those rules. […]
The one-line summary (first line) of the message does not follow the guidelines (should include the subsystem).

You should also reference the issue number in the commit message itself.

There are examples of both here: https://wiki.asterisk.org/wiki/display/AST/Commit+Messages



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16042
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: Ibfe359c5ce0338b2df9d1b2347bc684d4a21461a
Gerrit-Change-Number: 16042
Gerrit-PatchSet: 2
Gerrit-Owner: Ben Smithurst <ben.smithurst at gradwell.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Ben Smithurst <ben.smithurst at gradwell.com>
Gerrit-Comment-Date: Fri, 11 Jun 2021 13:44:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sean Bright <sean at seanbright.com>
Comment-In-Reply-To: Ben Smithurst <ben.smithurst at gradwell.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210611/e2e144a3/attachment.html>


More information about the asterisk-code-review mailing list