[Asterisk-code-review] pbx_builtins: Corrects SayNumber warning (asterisk[16])

[George Joseph]

Attention is currently required from: Sean Bright, N A.
George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16083 )

Change subject: pbx_builtins: Corrects SayNumber warning
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

File main/pbx_builtins.c:

https://gerrit.asterisk.org/c/asterisk/+/16083/comment/f2935881_64b2a8fc 
PS2, Line 1273: 	interrupt_string = pbx_builtin_getvar_helper(chan, "SAY_DTMF_INTERRUPT");
You could call ast_check_hangup() here since the channel is already locked.  This way the rest of the code doesn't even get executed if the channel is hung up.  It's fine to still have the ast_check_hangup_locked() below to suppress the message should that happen.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16083
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: Ieea4a67301c6ea83bbc7690c1d4808d79a704594
Gerrit-Change-Number: 16083
Gerrit-PatchSet: 2
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Sean Bright <sean at seanbright.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Comment-Date: Thu, 10 Jun 2021 17:06:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210610/69dd1689/attachment.html>