[Asterisk-code-review] app_dial: Prevent call from hanging (asterisk[master])

[N A]

Attention is currently required from: Joshua Colp.
N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/15985 )

Change subject: app_dial: Prevent call from hanging
......................................................................


Patch Set 2:

(2 comments)

File apps/app_dial.c:

https://gerrit.asterisk.org/c/asterisk/+/15985/comment/d78c37c8_61a2eec1 
PS1, Line 1801: 						/* If we're trying to send DTMF and the call has hung up
> Or to be more specific - until app_dial sees that a hangup has been queued on the channel and reads  […]
Ack


File apps/app_dial.c:

https://gerrit.asterisk.org/c/asterisk/+/15985/comment/3b24ed8a_8e051d38 
PS2, Line 1802: 						if (ast_check_hangup_locked(o->chan)) {
> I don't think this is sufficient documentation. […]
I'm honestly not sure why this isn't caught by another mechanism in Dial. I just tried this out, didn't expect it to work, and it does work, so it fixes this specific issue, though I'm not sure what the underlying cause is. The hangup doesn't seem to be making into Dial, but if we explicitly check when we're pretty sure that the outgoing channel has hung up, just to confirm, then we find that, indeed, the channel is gone.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/15985
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I6f2ee3f77b892015bc05513d868f071f279a3c80
Gerrit-Change-Number: 15985
Gerrit-PatchSet: 2
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Thu, 10 Jun 2021 15:26:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Comment-In-Reply-To: N A <mail at interlinked.x10host.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210610/1526b51c/attachment.html>