[Asterisk-code-review] res_stasis_playback: Send PlaybackFinish event only once for a list o... (asterisk[master])

Joshua Colp asteriskteam at digium.com
Wed Jun 9 11:51:39 CDT 2021


Attention is currently required from: Andre Barbosa.
Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/15987 )

Change subject: res_stasis_playback: Send PlaybackFinish event only once for a list of sounds, when we have errors
......................................................................


Patch Set 4:

(2 comments)

Commit Message:

https://gerrit.asterisk.org/c/asterisk/+/15987/comment/082b9a31_3e3ceb04 
PS3, Line 7: res_stasis_playback: Send PlaybackFinish event only once for a list of sounds, when we have errors
These should be wrapped at 80 characters.


Patchset:

PS4: 
Thinking further on this, I also think there should be a CHANGES entry[1] so ARI users are aware of this change.

[1] https://wiki.asterisk.org/wiki/display/AST/CHANGES+and+UPGRADE.txt



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/15987
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I4c2e5921cc597702513af0d7c6c2c982e1798322
Gerrit-Change-Number: 15987
Gerrit-PatchSet: 4
Gerrit-Owner: Andre Barbosa <andre.emanuel.barbosa at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Andre Barbosa <andre.emanuel.barbosa at gmail.com>
Gerrit-Comment-Date: Wed, 09 Jun 2021 16:51:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210609/d4deaa11/attachment.html>


More information about the asterisk-code-review mailing list