[Asterisk-code-review] app_reload: New Reload application (asterisk[16])

[Joshua Colp]

Attention is currently required from: N A, Kevin Harwell.
Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/15962 )

Change subject: app_reload: New Reload application
......................................................................


Patch Set 3:

(1 comment)

File apps/app_reload.c:

https://gerrit.asterisk.org/c/asterisk/+/15962/comment/211ed68c_4fdecafc 
PS3, Line 88: 	if (!ast_strlen_zero(target)) {
> Would it be reasonable to add it to the core as something more generic? But that might be a much lar […]
I don't think adding it to the core to facilitate this feature is really warranted. It would be touching a module that has worked for numerous years, and isn't actually aliasing module names but underlying CLI commands - which would then require you to parse out the resulting CLI command from the alias to support this feature. Common hardcoded things should be fine to document. The dynamic ones (like pjsip) is where trouble is.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/15962
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: Ic8ab025d8b38dd525b872b41c465c999c5810774
Gerrit-Change-Number: 15962
Gerrit-PatchSet: 3
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Attention: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Tue, 08 Jun 2021 15:03:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: N A <mail at interlinked.x10host.com>
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210608/d89c2084/attachment.html>