[Asterisk-code-review] app_reload: New Reload application (asterisk[16])

[Joshua Colp]

Attention is currently required from: N A, Kevin Harwell.
Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/15962 )

Change subject: app_reload: New Reload application
......................................................................


Patch Set 3:

(1 comment)

File apps/app_reload.c:

https://gerrit.asterisk.org/c/asterisk/+/15962/comment/eaeec5ef_4e1d2c90 
PS3, Line 88: 	if (!ast_strlen_zero(target)) {
I'm not going to -1 this, but I'm not going to +1 this as I'd like to get feedback from others. I don't think this is reasonable to embed such things in this module. Aliases exist purely from configuration driven by the CLI aliases module as the source. Duplicating/replicating this here is prone to issues if the defaults there change, or if a user changes them. The values in here won't match and people will be confused.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/15962
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: Ic8ab025d8b38dd525b872b41c465c999c5810774
Gerrit-Change-Number: 15962
Gerrit-PatchSet: 3
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Attention: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Tue, 08 Jun 2021 14:32:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210608/ac8253c1/attachment.html>