[Asterisk-code-review] sip_to_pjsip: Fix missing cases (asterisk[16])

Sean Bright asteriskteam at digium.com
Thu Jun 3 15:23:21 CDT 2021


Attention is currently required from: N A.
Sean Bright has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16010 )

Change subject: sip_to_pjsip: Fix missing cases
......................................................................


Patch Set 3: Code-Review-1

(1 comment)

File contrib/scripts/sip_to_pjsip/sip_to_pjsip.py:

https://gerrit.asterisk.org/c/asterisk/+/16010/comment/4ac5e4fd_68c28216 
PS3, Line 777:     if val == 'ALL':
There are a lot of OpenSSL'isms supported by chan_sip which this does not cover (HIGH, !LOW, etc). So if someone has anything other than "ALL" it will pass through and fail later.

Have this script print an informational message indicating that the user needs to address this setting manually.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16010
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: Ie27d6606efad3591038000e5f3c34fa94730f6f2
Gerrit-Change-Number: 16010
Gerrit-PatchSet: 3
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Comment-Date: Thu, 03 Jun 2021 20:23:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210603/08f7e8f2/attachment-0001.html>


More information about the asterisk-code-review mailing list