[Asterisk-code-review] sip_to_pjsip: Fix missing cases (asterisk[16])

N A asteriskteam at digium.com
Thu Jun 3 14:48:39 CDT 2021


Attention is currently required from: Sean Bright.
N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16010 )

Change subject: sip_to_pjsip: Fix missing cases
......................................................................


Patch Set 2:

(3 comments)

Patchset:

PS2: 
> What about the transport problem: […]
What transport problem? I don't see that in the JIRA issue ;)


File contrib/scripts/sip_to_pjsip/sip_to_pjsip.py:

https://gerrit.asterisk.org/c/asterisk/+/16010/comment/b1df005c_b83a2034 
PS2, Line 161:     if val == 'inband' or val == 'info':
> Just tack this on to the end: […]
Ack


https://gerrit.asterisk.org/c/asterisk/+/16010/comment/3213a4c0_38abeaf2 
PS2, Line 165:     elif val == 'auto':
             :         set_value(key, 'auto', section, pjsip, nmapped)
> Delete this
Ack



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16010
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: Ie27d6606efad3591038000e5f3c34fa94730f6f2
Gerrit-Change-Number: 16010
Gerrit-PatchSet: 2
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Sean Bright <sean at seanbright.com>
Gerrit-Comment-Date: Thu, 03 Jun 2021 19:48:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sean Bright <sean at seanbright.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210603/51a6d012/attachment-0001.html>


More information about the asterisk-code-review mailing list