[Asterisk-code-review] app_dial: Expanded A option to add caller announcement (asterisk[16])

[N A]

N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/15926 )

Change subject: app_dial: Expanded A option to add caller announcement
......................................................................


Patch Set 5:

(1 comment)

Patchset:

PS5: 
> Patch Set 5: Code-Review-1
> 
> This needs test coverage as well.

What might the goal/mechanism for this test look like? I'm not sure how to structure a test case such that we know this works, apart from maybe forking on answer and ensuring some amount of time has elapsed (for the files to play back), which doesn't seem like it would be rigorous enough.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/15926
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: If6eed3ff5c341dc8c588c8210987f2571e891e5e
Gerrit-Change-Number: 15926
Gerrit-PatchSet: 5
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Wed, 02 Jun 2021 15:36:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210602/e7fb27fe/attachment-0001.html>