[Asterisk-code-review] chan_iax2: Add encryption for RSA authentication (asterisk[16])

[N A]

Attention is currently required from: Joshua Colp, George Joseph.
N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/15934 )

Change subject: chan_iax2: Add encryption for RSA authentication
......................................................................


Patch Set 3:

(1 comment)

Patchset:

PS3: 
> Per comment from seanbright on IRC: […]
Correct, and this patch explicitly mitigates that. If I apply to this patch to my system, I can cause other systems calling me to crash (just like with MD5). This "bug" always existed and isn't being suddenly introduced. Furthermore, with RSA, a crash can't occur unless you have an explicit relationship set up in the config between 2 nodes, so it's unlikely that would happen, unlike with MD5 where nodes were crashing left and right. So I think rolling this out sooner rather than later would do more to prevent crashes.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/15934
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I18f1f9d7c59b4f9cffa00f3b94a4c875846efd40
Gerrit-Change-Number: 15934
Gerrit-PatchSet: 3
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: George Joseph <gjoseph at digium.com>
Gerrit-Comment-Date: Wed, 02 Jun 2021 12:47:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210602/e99fe5c3/attachment.html>