[Asterisk-code-review] app_queue: Allow streaming multiple announcement files (asterisk[master])

Sean Bright asteriskteam at digium.com
Sat Jul 31 11:06:17 CDT 2021


Attention is currently required from: N A.
Sean Bright has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16221 )

Change subject: app_queue: Allow streaming multiple announcement files
......................................................................


Patch Set 2:

(1 comment)

File apps/app_queue.c:

https://gerrit.asterisk.org/c/asterisk/+/16221/comment/8abf0f54_99d95568 
PS1, Line 6963: 					while ((front = strsep(&announce, "&"))) {
> I believe announce needs to be duplicated using ast_strdupa, or else this may modify "qe->announce"  […]
Marking resolved to clear the comment bubble from the review index page.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16221
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Iec600d8cd5ba14aa1e4e37f906accb356cd7891a
Gerrit-Change-Number: 16221
Gerrit-PatchSet: 2
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-CC: Sean Bright <sean at seanbright.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Comment-Date: Sat, 31 Jul 2021 16:06:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210731/a7fb8cdb/attachment.html>


More information about the asterisk-code-review mailing list