[Asterisk-code-review] sig_analog: Changes to improve electromechanical signalling compatibi... (asterisk[master])

Sean Bright asteriskteam at digium.com
Fri Jul 30 11:34:36 CDT 2021


Attention is currently required from: Joshua Colp, Sarah Autumn.
Sean Bright has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16151 )

Change subject: sig_analog: Changes to improve electromechanical signalling compatibility
......................................................................


Patch Set 4:

(1 comment)

File channels/chan_dahdi.h:

https://gerrit.asterisk.org/c/asterisk/+/16151/comment/524bd143_a299b34c 
PS3, Line 196: 	 * \brief INTEGER, length of time to wait before sending ANI wink in ms. 
> I just fixed this, but it didn't make it into the last patch. […]
Up to you whether you fix it now or later. I just wanted to point out that it was still marked as unresolved.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16151
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Ib7e27d987aee4ed9bc3663c57ef413e21b404256
Gerrit-Change-Number: 16151
Gerrit-PatchSet: 4
Gerrit-Owner: Sarah Autumn <sarah at endlesstemple.org>
Gerrit-Reviewer: Friendly Automation
Gerrit-CC: Joshua Colp <jcolp at sangoma.com>
Gerrit-CC: N A <mail at interlinked.x10host.com>
Gerrit-CC: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Sarah Autumn <sarah at endlesstemple.org>
Gerrit-Comment-Date: Fri, 30 Jul 2021 16:34:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Comment-In-Reply-To: Sarah Autumn <sarah at endlesstemple.org>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210730/f58f6f76/attachment-0001.html>


More information about the asterisk-code-review mailing list