[Asterisk-code-review] app_sendmf: New SendMF application (asterisk[master])

[N A]

Attention is currently required from: Joshua Colp, Sarah Autumn.
N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16080 )

Change subject: app_sendmf: New SendMF application
......................................................................


Patch Set 3:

(3 comments)

File apps/app_sendmf.c:

https://gerrit.asterisk.org/c/asterisk/+/16080/comment/1591ca86_0198d192 
PS2, Line 82: static int ast_senddigit_mf_begin(struct ast_channel *chan, char digit)
> ast_* is commonly used as a prefix to indicate a function used across the tree, not within a module  […]
Done


https://gerrit.asterisk.org/c/asterisk/+/16080/comment/de50306d_19ff20db 
PS2, Line 116: 		ast_debug(1, "Unable to generate MF tone '%c' for '%s'\n", digit, ast_channel_name(chan));
> Should this be a non-debug message so the user is aware of what has happened?
Done


https://gerrit.asterisk.org/c/asterisk/+/16080/comment/e4d3eb12_ddbbd1f6 
PS2, Line 232: 	if (peer && ast_autoservice_start(peer)) {
> Why/how could there be a peer?
To be completely frank, I don't know. I started using app_senddtmf as a base for this and modified it, so I retained the structure of that. I would imagine the rationale would be the same as with DTMF, though I don't know what that would be. Can remove if unneeded.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16080
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I5d89afdbccee3f86cc702ed96d882f3d351327a4
Gerrit-Change-Number: 16080
Gerrit-PatchSet: 3
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-CC: Sarah Autumn <sarah at endlesstemple.org>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Sarah Autumn <sarah at endlesstemple.org>
Gerrit-Comment-Date: Thu, 29 Jul 2021 20:57:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210729/1f8dfeda/attachment-0001.html>