[Asterisk-code-review] logger: Add custom logging capabilities (asterisk[master])

Joshua Colp asteriskteam at digium.com
Thu Jul 29 15:54:45 CDT 2021


Attention is currently required from: N A.
Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16222 )

Change subject: logger: Add custom logging capabilities
......................................................................


Patch Set 4: Code-Review-1

(1 comment)

File main/logger.c:

https://gerrit.asterisk.org/c/asterisk/+/16222/comment/7f2d6854_e5665061 
PS4, Line 1898: 	ast_config_destroy(cfg);
You can't call ast_config_destroy every time, as there are special return values from ast_config_load2. As well you didn't answer my question regarding init_logger_chain.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16222
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: If082703cf81a436ae5a565c75225fa8c0554b702
Gerrit-Change-Number: 16222
Gerrit-PatchSet: 4
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Comment-Date: Thu, 29 Jul 2021 20:54:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210729/122c4ade/attachment.html>


More information about the asterisk-code-review mailing list