[Asterisk-code-review] logger: Add custom logging capabilities (asterisk[master])

[Joshua Colp]

Attention is currently required from: N A.
Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16222 )

Change subject: logger: Add custom logging capabilities
......................................................................


Patch Set 3: Code-Review-1

(4 comments)

File configs/samples/logger.conf.sample:

https://gerrit.asterisk.org/c/asterisk/+/16222/comment/c309889c_2eede000 
PS3, Line 88: ; Any custom logging levels you may want to use, which can then
This doesn't specify or show an example of how multiple are specified


File include/asterisk/logger.h:

https://gerrit.asterisk.org/c/asterisk/+/16222/comment/8dd26f44_326a5fe5 
PS3, Line 338: int ast_dynamic_logger_level_exists(const char *name);
The name of this function does not match the behavior. An exists function usually returns 1 if something exists, and 0 if it doesn't. This function actually returns the level to use for logging.


File main/logger.c:

https://gerrit.asterisk.org/c/asterisk/+/16222/comment/2714b258_f3faea9c 
PS3, Line 1887: 	if (!(!(cfg = ast_config_load2("logger.conf", "logger", config_flags)) || cfg == CONFIG_STATUS_FILEINVALID)) {
Is there a reason that modifying the existing init_logger_chain is insufficient?


https://gerrit.asterisk.org/c/asterisk/+/16222/comment/408296fe_cb6d1846 
PS3, Line 1897: 	}
This leaks the configuration.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16222
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: If082703cf81a436ae5a565c75225fa8c0554b702
Gerrit-Change-Number: 16222
Gerrit-PatchSet: 3
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Comment-Date: Thu, 29 Jul 2021 12:03:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210729/840f8661/attachment-0001.html>