[Asterisk-code-review] res_pjsip_registrar: Remove unavailable contacts if exceeds max_contacts (asterisk[16])

Joe asteriskteam at digium.com
Mon Jul 26 12:21:02 CDT 2021


Attention is currently required from: Joshua Colp.
Joe has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16160 )

Change subject: res_pjsip_registrar: Remove unavailable contacts if exceeds max_contacts
......................................................................


Patch Set 2:

(1 comment)

Commit Message:

https://gerrit.asterisk.org/c/asterisk/+/16160/comment/4b59d9de_50524683 
PS2, Line 15: This commit changes this behavior, to remove unavailable contacts
> Ack
Should an option be created for both parts of the code (e.g. when remove_existing is yes, make an option if unavail should be first, and if remove_existing is no then should unavail be removed at all)?  This will end up created a whole bunch of options and can get confusing.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16160
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: Ia2711b08f2b4d1177411b1be23e970d7fdff5784
Gerrit-Change-Number: 16160
Gerrit-PatchSet: 2
Gerrit-Owner: Joe <ynadiv at corpit.xyz>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Mon, 26 Jul 2021 17:21:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Comment-In-Reply-To: Joe <ynadiv at corpit.xyz>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210726/e72ae255/attachment.html>


More information about the asterisk-code-review mailing list