[Asterisk-code-review] logger: Add custom logging level (asterisk[master])

N A asteriskteam at digium.com
Mon Jul 26 08:13:01 CDT 2021


Attention is currently required from: Joshua Colp.
N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16222 )

Change subject: logger: Add custom logging level
......................................................................


Patch Set 1:

(1 comment)

Patchset:

PS1: 
> I don't think [custom] would be very good. […]
The verbose logger as a whole seems tightly coupled to integer log levels, so I'm not sure how something like same => n,Verbose(custom-level-name,Test) would fit in easily without changing a lot of this.
I see this is how it dynamically can register custom logging channels: https://github.com/asterisk/asterisk/blob/b4347c486150653ec7ce1d129e8f9017c69344da/main/logger.c#L813
But I'm not seeing where the logger can register custom logging levels.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16222
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: If082703cf81a436ae5a565c75225fa8c0554b702
Gerrit-Change-Number: 16222
Gerrit-PatchSet: 1
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Mon, 26 Jul 2021 13:13:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Comment-In-Reply-To: N A <mail at interlinked.x10host.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210726/a90ddaa4/attachment.html>


More information about the asterisk-code-review mailing list