[Asterisk-code-review] app_queue: Allow streaming multiple announcement files (asterisk[master])

[Joshua Colp]

Attention is currently required from: N A.
Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16221 )

Change subject: app_queue: Allow streaming multiple announcement files
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

File apps/app_queue.c:

https://gerrit.asterisk.org/c/asterisk/+/16221/comment/e161e32c_f4d86935 
PS1, Line 6963: 					while ((front = strsep(&announce, "&"))) {
I believe announce needs to be duplicated using ast_strdupa, or else this may modify "qe->announce" resulting in incorrect behavior.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16221
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Iec600d8cd5ba14aa1e4e37f906accb356cd7891a
Gerrit-Change-Number: 16221
Gerrit-PatchSet: 1
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Comment-Date: Mon, 26 Jul 2021 11:44:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210726/6f806739/attachment.html>