[Asterisk-code-review] res_pjsip_stir_shaken: Use correct Caller ID to lookup certificate. (asterisk[16])

[George Joseph]

Attention is currently required from: Sean Bright, Benjamin Keith Ford.
George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16153 )

Change subject: res_pjsip_stir_shaken: Use correct Caller ID to lookup certificate.
......................................................................


Patch Set 5:

(1 comment)

Patchset:

PS5: 
> Yeah, the connected line info is null so we don't add the Identity header on the INVITE. Any thought on what to do in this case?

Interesting issue.  In this case, there's only 1 channel and no callerid/connectedline at all.  It gopt me thinking though... I think we're going to have a similar issue when there are 2 channels but callerid_privacy is set to "prohib".  In this case, the From gets set to Anonymous and PAI and RPID are suppressed on the outgoing INVITE BUT the connected line is still set on the channel.  We _could_ therefore still send an attestation but should we?



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16153
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I6f1f9c56ceb989d3ad4e16f069b4273166614b9a
Gerrit-Change-Number: 16153
Gerrit-PatchSet: 5
Gerrit-Owner: Sean Bright <sean at seanbright.com>
Gerrit-Reviewer: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Attention: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Benjamin Keith Ford <bford at digium.com>
Gerrit-Comment-Date: Wed, 21 Jul 2021 13:40:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sean Bright <sean at seanbright.com>
Comment-In-Reply-To: Benjamin Keith Ford <bford at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210721/ba6838f7/attachment-0001.html>