[Asterisk-code-review] func_lookup: Fork of HINT function (asterisk[master])

N A asteriskteam at digium.com
Mon Jul 19 18:32:45 CDT 2021


Attention is currently required from: Joshua Colp.
N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16075 )

Change subject: func_lookup: Fork of HINT function
......................................................................


Patch Set 4:

(1 comment)

Patchset:

PS4: 
> I should also add that GoSub doesn't change the PBX core or alter it with another priority like this […]
By talking about usage of Gosub, we're discussing semantics of intended usage, as opposed to what it actually does technically.

If the issue here is the priority, then what if there were no changes to the core and it looked something like this?

[lookup]
exten => 345,1,52
exten => _34X,1,${EXTEN}
exten => _4XX,1,${EXTEN}
exten => same => n,Hello World
exten => _4XX,3,${CURL(http://url)})

[elsewhere]
exten => _XXX,1,Gosub(my-context,s,1(${LOOKUP(${EXTEN}@lookup,1)})

Now, LOOKUP is simply returning the application value at context,exten,priority and parsing the value. No changes to the PBX core, completely isolated. This makes it even more explicitly dialplan based, a synonymous function name may as well be DIALPLAN_VALUE, so even more generic than what I initially intended.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16075
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Iad81019689674c9f4ac77d235f5d7234adbb1432
Gerrit-Change-Number: 16075
Gerrit-PatchSet: 4
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Sarah Autumn <sarah at endlesstemple.org>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Mon, 19 Jul 2021 23:32:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Comment-In-Reply-To: N A <mail at interlinked.x10host.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210719/7278e04f/attachment.html>


More information about the asterisk-code-review mailing list