[Asterisk-code-review] app_dtmfstore: New application to store digits (asterisk[master])

[N A]

Attention is currently required from: Joshua Colp.
N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16070 )

Change subject: app_dtmfstore: New application to store digits
......................................................................


Patch Set 4:

(1 comment)

Patchset:

PS3: 
> So for some reason, only the last digit received is getting stored now because each callback invocat […]
Upon closer examination, it seems that this only affects CDR() variables and presumably other function values as well. "Regular" variables, e.g. testvar, work correctly. With something like StoreDTMF(RX,CDR(testvar),24), only the last digit gets saved, because the callback is unable to retrieve whatever ${CDR(testvar)} currently is, so it starts over. Replacing pbx_builtin_getvar_helper with pbx_substitute_variables_helper fixes this issue.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16070
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I51aa93fc9507f7636ac44806c4420ce690423e6f
Gerrit-Change-Number: 16070
Gerrit-PatchSet: 4
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: N A <mail at interlinked.x10host.com>
Gerrit-CC: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Mon, 19 Jul 2021 21:11:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: N A <mail at interlinked.x10host.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210719/7d12bb50/attachment.html>