[Asterisk-code-review] func_frame_drop: New function (asterisk[master])

[N A]

Attention is currently required from: Joshua Colp.
N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16071 )

Change subject: func_frame_drop: New function
......................................................................


Patch Set 9:

(1 comment)

File funcs/func_frame_drop.c:

https://gerrit.asterisk.org/c/asterisk/+/16071/comment/76bc04aa_048e974d 
PS9, Line 196: 	if (drop_frame) {
> It would solve it for the voice case I believe, but as I've stated multiple times I'm not sure of th […]
Is this the command that should be used to test this kind of thing? https://wiki.asterisk.org/wiki/display/AST/Valgrind

This is the output from running a call with a few frame drops, then core stop now to cleanly end:
==14788== HEAP SUMMARY:
==14788==     in use at exit: 49,616,315 bytes in 191,253 blocks
==14788==   total heap usage: 5,093,761 allocs, 4,902,508 frees, 349,224,497 bytes allocated
==14788==
==14788== LEAK SUMMARY:
==14788==    definitely lost: 145,552 bytes in 2,488 blocks
==14788==    indirectly lost: 256 bytes in 8 blocks
==14788==      possibly lost: 5,511,377 bytes in 16,720 blocks
==14788==    still reachable: 43,959,130 bytes in 172,037 blocks
==14788==                       of which reachable via heuristic:
==14788==                         newarray           : 1,624 bytes in 17 blocks
==14788==         suppressed: 0 bytes in 0 blocks
==14788== Rerun with --leak-check=full to see details of leaked memory
==14788==
==14788== For counts of detected and suppressed errors, rerun with: -v
==14788== ERROR SUMMARY: 0 errors from 0 contexts (suppressed: 0 from 0)

This is killing Asterisk with CTRL+C:
==14685== HEAP SUMMARY:
==14685==     in use at exit: 49,584,871 bytes in 191,393 blocks
==14685==   total heap usage: 5,095,424 allocs, 4,904,031 frees, 348,076,580 bytes allocated
==14685==
==14685== LEAK SUMMARY:
==14685==    definitely lost: 125,248 bytes in 2,626 blocks
==14685==    indirectly lost: 160 bytes in 5 blocks
==14685==      possibly lost: 5,509,155 bytes in 16,718 blocks
==14685==    still reachable: 43,950,308 bytes in 172,044 blocks
==14685==                       of which reachable via heuristic:
==14685==                         newarray           : 1,624 bytes in 17 blocks
==14685==         suppressed: 0 bytes in 0 blocks
==14685== Rerun with --leak-check=full to see details of leaked memory
==14685==
==14685== For counts of detected and suppressed errors, rerun with: -v
==14685== ERROR SUMMARY: 0 errors from 0 contexts (suppressed: 0 from 0)



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16071
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I8147c9d55d74e2e48861edba6b22f930920541ec
Gerrit-Change-Number: 16071
Gerrit-PatchSet: 9
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Mon, 19 Jul 2021 19:36:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Comment-In-Reply-To: N A <mail at interlinked.x10host.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210719/693a4e65/attachment.html>