[Asterisk-code-review] chan_iax2: Add encryption for RSA authentication (asterisk[16])

[N A]

Attention is currently required from: Joshua Colp, George Joseph.
N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/15934 )

Change subject: chan_iax2: Add encryption for RSA authentication
......................................................................


Patch Set 3:

(1 comment)

Patchset:

PS3: 
> Actually, doing -2 for now as it will carry over.
I spent some time today testing some various scenarios. On patched servers, all scenarios of md5->md5, md5->md5/rsa, md5/rsa->md5, nad md5/rsa->md5/rsa do work without issues. If there is an issue (wrong secret, no secret, no encryption) it fails gracefully with the correct errors. I'm also now running combined md5/rsa users in prod as well single rsa and no issues there, either.
Likewise, no problem calling from a patched server -> unpatched server, though I didn't expect there to be.
Unpatched -> patched, a crash occurs on the unpatched server if the result is an encrypted rsa call.
Setting up a testsuite for this would confirm any regressions for certain, but I'm not sure how it would work two parallel IAXs for the test, without 2 Asterisks running.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/15934
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I18f1f9d7c59b4f9cffa00f3b94a4c875846efd40
Gerrit-Change-Number: 15934
Gerrit-PatchSet: 3
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: George Joseph <gjoseph at digium.com>
Gerrit-Comment-Date: Mon, 19 Jul 2021 19:17:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210719/d29bdd65/attachment.html>