[Asterisk-code-review] res_pjsip_stir_shaken: Use correct Caller ID to lookup certificate. (asterisk[master])

[Sean Bright]

Attention is currently required from: Richard Mudgett.
Sean Bright has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16175 )

Change subject: res_pjsip_stir_shaken: Use correct Caller ID to lookup certificate.
......................................................................


Patch Set 3:

(2 comments)

File res/res_pjsip_stir_shaken.c:

https://gerrit.asterisk.org/c/asterisk/+/16175/comment/d7f5d361_6127fdea 
PS2, Line 211: static int add_identity_header(const struct ast_sip_session *session, const struct ast_party_id *party_id, pjsip_tx_data *tdata)
> The session parameter does not seem to be used in this function anymore
Ack


https://gerrit.asterisk.org/c/asterisk/+/16175/comment/2f682cdf_a8d03195 
PS2, Line 351: 		return;
> You need to ast_party_id_free(&connected_id) here before returning.  Memory leak.
Ack



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16175
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I6f1f9c56ceb989d3ad4e16f069b4273166614b9a
Gerrit-Change-Number: 16175
Gerrit-PatchSet: 3
Gerrit-Owner: Sean Bright <sean at seanbright.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Attention: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Thu, 15 Jul 2021 21:42:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Richard Mudgett <rmudgett at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210715/dcd31741/attachment.html>