[Asterisk-code-review] res_statsd: handle non-standard meter type safely (asterisk[16])

[Joshua Colp]

Attention is currently required from: Rijnhard Hessel.
Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16149 )

Change subject: res_statsd: handle non-standard meter type safely
......................................................................


Patch Set 6: Code-Review-1

(2 comments)

Patchset:

PS6: 
The sample configuration file needs to be updated to include the new option along with an explanation.  This also needs a CHANGES[1] entry.

[1] https://wiki.asterisk.org/wiki/display/AST/CHANGES+and+UPGRADE.txt


File res/res_statsd.c:

https://gerrit.asterisk.org/c/asterisk/+/16149/comment/811e782b_9f5ebb78 
PS6, Line 61: 				<configOption name="meter_support">
I think this needs further clarification that the name will include _meter at the end if it falls back to counter.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16149
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I5fcb385983a1b88f03696ff30a26b55c546a1dd7
Gerrit-Change-Number: 16149
Gerrit-PatchSet: 6
Gerrit-Owner: Rijnhard Hessel <rijnhard at teleforge.co.za>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Rijnhard Hessel <rijnhard at teleforge.co.za>
Gerrit-Comment-Date: Thu, 15 Jul 2021 12:45:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210715/b668a294/attachment.html>