[Asterisk-code-review] stun: Emit warning message when STUN request times out (asterisk[16])

[Sébastien Duthil]

Attention is currently required from: Joshua Colp, George Joseph.
Sébastien Duthil has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16166 )

Change subject: stun: Emit warning message when STUN request times out
......................................................................


Patch Set 4:

(1 comment)

File main/stun.c:

https://gerrit.asterisk.org/c/asterisk/+/16166/comment/a61a8590_7d528ebb 
PS2, Line 441: 				ast_log(LOG_WARNING,
> Do we want the warning on every try or only if retries have been exhausted?  Just thinking of log sp […]
I implemented your suggestion and extracted the log messages to their own function to avoid too much duplication. Comments welcome :)



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16166
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I26e4853c23a1aed324552e1b9683ea3c05cb1f74
Gerrit-Change-Number: 16166
Gerrit-PatchSet: 4
Gerrit-Owner: Sébastien Duthil <sduthil at wazo.community>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: George Joseph <gjoseph at digium.com>
Gerrit-Comment-Date: Mon, 12 Jul 2021 22:02:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: George Joseph <gjoseph at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210712/13bf1199/attachment.html>