[Asterisk-code-review] res_pjsip_header_funcs: Add PJSIP_HEADERS() ability to read header by... (asterisk[master])

[Igor Goncharovsky]

Attention is currently required from: Alexei Gradinari, George Joseph.
Igor Goncharovsky has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/15761 )

Change subject: res_pjsip_header_funcs: Add PJSIP_HEADERS() ability to read header by pattern
......................................................................


Patch Set 6:

(2 comments)

Patchset:

PS4: 
> Igor, It looks like you acked all the comments and uploaded a new patchset (4) but it's the same as  […]
I missed fact that new patch was not uploaded, would do it. Also this change made for master, should I re-create it for the 16 and then cherry pick to 18 and master?


File res/res_pjsip_header_funcs.c:

https://gerrit.asterisk.org/c/asterisk/+/15761/comment/519ea044_588b2255 
PS5, Line 411: 	pj_hdr_string_len = pjsip_hdr_print_on(hdr, pj_hdr_string, data->len);
> 1. The size of the buffer should be data->len - 1 […]
Done



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/15761
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Ic09d395de71a0021e0d6c5c29e1e19d689079f8b
Gerrit-Change-Number: 15761
Gerrit-PatchSet: 6
Gerrit-Owner: Igor Goncharovsky <igor.goncharovsky at gmail.com>
Gerrit-Reviewer: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Attention: George Joseph <gjoseph at digium.com>
Gerrit-Comment-Date: Thu, 08 Jul 2021 15:38:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Alexei Gradinari <alex2grad at gmail.com>
Comment-In-Reply-To: George Joseph <gjoseph at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210708/53425383/attachment-0001.html>