[Asterisk-code-review] stun: Emit warning message when STUN request times out (asterisk[16])

[George Joseph]

Attention is currently required from: Joshua Colp, Sébastien Duthil.
George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16166 )

Change subject: stun: Emit warning message when STUN request times out
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

File main/stun.c:

https://gerrit.asterisk.org/c/asterisk/+/16166/comment/6801ca80_74602443 
PS2, Line 441: 				ast_log(LOG_WARNING,
Do we want the warning on every try or only if retries have been exhausted?  Just thinking of log spam.  Maybe make the individual timeouts debug or NOTICE messages and only the final one the warning.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16166
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I26e4853c23a1aed324552e1b9683ea3c05cb1f74
Gerrit-Change-Number: 16166
Gerrit-PatchSet: 2
Gerrit-Owner: Sébastien Duthil <sduthil at wazo.community>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Sébastien Duthil <sduthil at wazo.community>
Gerrit-Comment-Date: Thu, 08 Jul 2021 14:39:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210708/baff449a/attachment-0001.html>