[Asterisk-code-review] res_statsd: handle non-standard meter type safely (asterisk[16])

[Rijnhard Hessel]

Attention is currently required from: Joshua Colp.
Rijnhard Hessel has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16149 )

Change subject: res_statsd: handle non-standard meter type safely
......................................................................


Patch Set 4:

(2 comments)

Patchset:

PS4: 
I've geven


File res/res_chan_stats.c:

https://gerrit.asterisk.org/c/asterisk/+/16149/comment/4b90d070_af21c438 
PS1, Line 76: 		ast_statsd_log(ast_str_buffer(metric), AST_STATSD_COUNTER, 1);
> I think a simple "meter_support", with documentation of what happens to meters if disabled (counter  […]
are the latest changes suitable? (FYI this is my first time working on the codebase).

The current changeset is fully backwards compatible as it defaults to existing behaviour, which makes the fallback opt-in.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16149
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I5fcb385983a1b88f03696ff30a26b55c546a1dd7
Gerrit-Change-Number: 16149
Gerrit-PatchSet: 4
Gerrit-Owner: Rijnhard Hessel <rijnhard at teleforge.co.za>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Thu, 08 Jul 2021 12:24:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Comment-In-Reply-To: Rijnhard Hessel <rijnhard at teleforge.co.za>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210708/8bd8b31b/attachment.html>