[Asterisk-code-review] res_statsd: replace meter type with counter (asterisk[16])

[Joshua Colp]

Attention is currently required from: Rijnhard Hessel.
Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16149 )

Change subject: res_statsd: replace meter type with counter
......................................................................


Patch Set 1: Code-Review-1

(3 comments)

Commit Message:

https://gerrit.asterisk.org/c/asterisk/+/16149/comment/3338043d_6797133a 
PS1, Line 8: 
This commit message needs more explanation as to why this change is being done.


File include/asterisk/statsd.h:

https://gerrit.asterisk.org/c/asterisk/+/16149/comment/c7acea9e_fe6b7e3c 
PS1, Line 44: /*! Events over time. Sorta like increment-only counters. */
This is a publicly defined API. I don't think this should be removed in non-master branches, a comment explaining why it should not be used should be replaced instead.


File res/res_chan_stats.c:

https://gerrit.asterisk.org/c/asterisk/+/16149/comment/19fa85c1_81c63096 
PS1, Line 76: 		ast_statsd_log(ast_str_buffer(metric), AST_STATSD_COUNTER, 1);
What impact does this have to any potential existing users?



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16149
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I5fcb385983a1b88f03696ff30a26b55c546a1dd7
Gerrit-Change-Number: 16149
Gerrit-PatchSet: 1
Gerrit-Owner: Rijnhard Hessel <rijnhard at teleforge.co.za>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-CC: Friendly Automation
Gerrit-Attention: Rijnhard Hessel <rijnhard at teleforge.co.za>
Gerrit-Comment-Date: Thu, 08 Jul 2021 09:57:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210708/36c05fdd/attachment.html>