[Asterisk-code-review] res_stasis_playback: Check for chan hangup on play_on_channels (asterisk[master])

George Joseph asteriskteam at digium.com
Tue Jul 6 08:22:24 CDT 2021


Attention is currently required from: Andre Barbosa.
George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16141 )

Change subject: res_stasis_playback: Check for chan hangup on play_on_channels
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

File res/res_stasis_playback.c:

https://gerrit.asterisk.org/c/asterisk/+/16141/comment/9dcb85a1_7be273e7 
PS1, Line 387: 			ast_log(LOG_NOTICE, "Channel: %s already hangup, stop playback\n", ast_channel_name(chan));
There's nothing a pbx admin could or should do about this so I'd make this a debug rather than a notice.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16141
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Ic4e1c01b974c9a1f2d9678c9d6b380bcfc69feb8
Gerrit-Change-Number: 16141
Gerrit-PatchSet: 1
Gerrit-Owner: Andre Barbosa <andre.emanuel.barbosa at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Andre Barbosa <andre.emanuel.barbosa at gmail.com>
Gerrit-Comment-Date: Tue, 06 Jul 2021 13:22:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210706/e892cee2/attachment.html>


More information about the asterisk-code-review mailing list