[Asterisk-code-review] stun: Emit warning message when STUN request times out (asterisk[16])

[Joshua Colp]

Attention is currently required from: Sébastien Duthil.
Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16166 )

Change subject: stun: Emit warning message when STUN request times out
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

File main/stun.c:

https://gerrit.asterisk.org/c/asterisk/+/16166/comment/5adec7fb_b1ae482f 
PS1, Line 441: 				ast_log(LOG_WARNING, "STUN request number %d timed out.\n", retry);
I don't think from a user perspective this is detailed or friendly enough. I think it should include actionable information such as:

"Attempt %d to send STUN request to 'server address' timed out. Check that the server address is correct and reachable."



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16166
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I26e4853c23a1aed324552e1b9683ea3c05cb1f74
Gerrit-Change-Number: 16166
Gerrit-PatchSet: 1
Gerrit-Owner: Sébastien Duthil <sduthil at wazo.community>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Sébastien Duthil <sduthil at wazo.community>
Gerrit-Comment-Date: Tue, 06 Jul 2021 08:59:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210706/6a8a9d09/attachment.html>