[Asterisk-code-review] app_stack: Adds conditional return application (asterisk[master])

N A asteriskteam at digium.com
Thu Jul 1 06:12:02 CDT 2021


Attention is currently required from: Corey Farrell.
N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16077 )

Change subject: app_stack: Adds conditional return application
......................................................................


Patch Set 2:

(1 comment)

Patchset:

PS2: 
> We already have ExecIf which can be used to return only if a condition is true, alternatively you co […]
Just a thought, couldn't the exact same thing be said about the GotoIf and GosubIf applications though? They can trivially be done using ExecIf. This is just the inverse of GosubIf.
GotoIf doesn't work well if there are several possible return points, in which case it really has to be done on the same line. The main thing I was thinking was returning only on true (currently requires an ExecIf($[]?Return)) which can get messy with nested conditionals. I already use Return(${IF()}) as you described if I'll be returning for sure.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16077
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I046b778bd98a2aa97bd58b058ee77f7504407425
Gerrit-Change-Number: 16077
Gerrit-PatchSet: 2
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Attention: Corey Farrell <git at cfware.com>
Gerrit-Comment-Date: Thu, 01 Jul 2021 11:12:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Corey Farrell <git at cfware.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210701/3fe1f8e9/attachment.html>


More information about the asterisk-code-review mailing list