[Asterisk-code-review] chan_iax2.c: Require secret and auth method if encryption is enabled (asterisk[16])

[George Joseph]

Hello Friendly Automation, Benjamin Keith Ford, 

I'd like you to reexamine a change. Please visit

    https://gerrit.asterisk.org/c/asterisk/+/15387

to look at the new patch set (#3).

Change subject: chan_iax2.c: Require secret and auth method if encryption is enabled
......................................................................

chan_iax2.c: Require secret and auth method if encryption is enabled

If there's no secret specified for an iax2 peer and there's no secret
specified in the dial string, Asterisk will crash if the auth method
is empty, MD5 or plaintext.  You also couldn't specify a default auth
method in the [general] section of iax.conf so if you don't have
static peers defined and just use the dial string, Asterisk will
still crash even if you have a secret specified in the dial string.

* Added the ability to specify a default "auth" in the [general]
  section of iax.conf.

* Added warnings to iax2_call() if (force)encryption is set and
  there's no secret or auth method.  The call is cancelled in
  these cases.

ASTERISK-29624
Reported by: N A

Change-Id: I5928e16137581f7d383fcc7fa04ad96c919e6254
---
M channels/chan_iax2.c
M configs/samples/iax.conf.sample
A doc/CHANGES-staging/chan_iax2.txt
3 files changed, 34 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/87/15387/3
-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/15387
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I5928e16137581f7d383fcc7fa04ad96c919e6254
Gerrit-Change-Number: 15387
Gerrit-PatchSet: 3
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-CC: George Joseph - Unused <gjoseph+unused at digium.com>
Gerrit-MessageType: newpatchset
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210129/b45416ec/attachment.html>