[Asterisk-code-review] chan_sip: Set up calls without audio (text+video), again. (asterisk[16])

[Alexander Traud]

Alexander Traud has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/15379 )

Change subject: chan_sip: Set up calls without audio (text+video), again.
......................................................................


Patch Set 1:

My previous change was about the core, main/channel.c. Furthermore, at that time, when I had fixed that, I did not understand all channels. This change here is about channels/chan_sip.c. It took some time and research to understand why this change is needed but was not required 13 years ago: There was a guard, introduced decades ago, which checked whether at least one format is offered/requested. However, that guard was wrongly limited to at least one *audio* format.

Different view: To make video+text work, this change here depends on the previous change. However, that previous change does not depend on this one. First, the core had to be fixed in general. Then, the channel chan_sip.

Finally, I did not withhold this change here. I finished it and its analysis just yesterday. At that time, coincidently, the previous change was ‘through’.

Does this answer your question? Or are you asking that such things should happen in one single change in future?


-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/15379
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: Ic16a3bf13cd1b5c4fc4041ed74961177d96b600f
Gerrit-Change-Number: 15379
Gerrit-PatchSet: 1
Gerrit-Owner: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Comment-Date: Thu, 28 Jan 2021 09:42:35 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210128/8be75645/attachment.html>