[Asterisk-code-review] main/frame: Add missing control frame names to ast_frame_subclass2str (asterisk[18])
Joshua Colp
asteriskteam at digium.com
Wed Jan 27 10:04:33 CST 2021
Joshua Colp has submitted this change. ( https://gerrit.asterisk.org/c/asterisk/+/15369 )
Change subject: main/frame: Add missing control frame names to ast_frame_subclass2str
......................................................................
main/frame: Add missing control frame names to ast_frame_subclass2str
Log proper control frame names instead of "Unknown control '14'", etc.
Change-Id: I1724f2f4d1b064b25a5c93a7da0cb03be5143935
---
M main/frame.c
1 file changed, 9 insertions(+), 0 deletions(-)
Approvals:
Joshua Colp: Looks good to me, but someone else must approve; Approved for Submit
Sean Bright: Looks good to me, but someone else must approve
George Joseph: Looks good to me, approved
diff --git a/main/frame.c b/main/frame.c
index 3a5ee91..711f9e1 100644
--- a/main/frame.c
+++ b/main/frame.c
@@ -459,12 +459,21 @@
case AST_CONTROL_RADIO_UNKEY:
ast_copy_string(subclass, "Unkey Radio", slen);
break;
+ case AST_CONTROL_PROGRESS:
+ ast_copy_string(subclass, "Progress", slen);
+ break;
+ case AST_CONTROL_PROCEEDING:
+ ast_copy_string(subclass, "Proceeding", slen);
+ break;
case AST_CONTROL_HOLD:
ast_copy_string(subclass, "Hold", slen);
break;
case AST_CONTROL_UNHOLD:
ast_copy_string(subclass, "Unhold", slen);
break;
+ case AST_CONTROL_VIDUPDATE:
+ ast_copy_string(subclass, "Video Update", slen);
+ break;
case AST_CONTROL_T38_PARAMETERS: {
char *message = "Unknown";
if (f->datalen != sizeof(struct ast_control_t38_parameters)) {
--
To view, visit https://gerrit.asterisk.org/c/asterisk/+/15369
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings
Gerrit-Project: asterisk
Gerrit-Branch: 18
Gerrit-Change-Id: I1724f2f4d1b064b25a5c93a7da0cb03be5143935
Gerrit-Change-Number: 15369
Gerrit-PatchSet: 3
Gerrit-Owner: Ivan Poddubny <ivan.poddubny at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210127/153b5261/attachment.html>
More information about the asterisk-code-review
mailing list