[Asterisk-code-review] chan_pjsip, app_transfer: Add TRANSFERSTATUSPROTOCOL variable (asterisk[16])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/15368 )

Change subject: chan_pjsip, app_transfer: Add TRANSFERSTATUSPROTOCOL variable
......................................................................


Patch Set 3: Code-Review-1

(5 comments)

This also needs a CHANGES[1] text file.

[1] https://wiki.asterisk.org/wiki/display/AST/CHANGES+and+UPGRADE.txt

https://gerrit.asterisk.org/c/asterisk/+/15368/3/apps/app_transfer.c 
File apps/app_transfer.c:

https://gerrit.asterisk.org/c/asterisk/+/15368/3/apps/app_transfer.c@76 
PS3, Line 76: 					<value name="3xx-6xx">
This should be as an example if using SIP


https://gerrit.asterisk.org/c/asterisk/+/15368/3/channels/chan_pjsip.c 
File channels/chan_pjsip.c:

https://gerrit.asterisk.org/c/asterisk/+/15368/3/channels/chan_pjsip.c@1998 
PS3, Line 1998: 			}
We put else ifs on the same line as the }


https://gerrit.asterisk.org/c/asterisk/+/15368/3/include/asterisk/channel.h 
File include/asterisk/channel.h:

https://gerrit.asterisk.org/c/asterisk/+/15368/3/include/asterisk/channel.h@2588 
PS3, Line 2588:  * \param protocol code for transfer
code for transfer doesn't really explain much - a better description would be "protocol specific code in case of failure"


https://gerrit.asterisk.org/c/asterisk/+/15368/3/main/channel.c 
File main/channel.c:

https://gerrit.asterisk.org/c/asterisk/+/15368/3/main/channel.c@6503 
PS3, Line 6503: 	if(protocol)
{ and } and space after if


https://gerrit.asterisk.org/c/asterisk/+/15368/3/main/channel.c@6543 
PS3, Line 6543: 				if(protocol)
{ and } and space after if



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/15368
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: Ia6a94784b4925628af122409cdd733c9f29abfc4
Gerrit-Change-Number: 15368
Gerrit-PatchSet: 3
Gerrit-Owner: Dan Cropp <dan at amtelco.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-CC: Sean Bright <sean.bright at gmail.com>
Gerrit-Comment-Date: Tue, 26 Jan 2021 13:41:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210126/b7cd76ac/attachment-0001.html>