[Asterisk-code-review] res_pjsip_pidf_digium_body_supplement: Support Sangoma user agent. (asterisk[certified/16.8])

[George Joseph]

Hello Joshua Colp,

I'd like you to do a code review. Please visit

    https://gerrit.asterisk.org/c/asterisk/+/15373

to review the following change.


Change subject: res_pjsip_pidf_digium_body_supplement: Support Sangoma user agent.
......................................................................

res_pjsip_pidf_digium_body_supplement: Support Sangoma user agent.

This adds support for both Digium and Sangoma user agent strings
for the Sangoma specific body supplement.

Change-Id: Ib99362b24b91d3cbe888d8b2fce3fad5515d9482
(cherry picked from commit 7e4bb4ed11b2741ff6cd47a95fb6e815a5e1d901)
---
M res/res_pjsip_pidf_digium_body_supplement.c
1 file changed, 5 insertions(+), 3 deletions(-)



  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/73/15373/1

diff --git a/res/res_pjsip_pidf_digium_body_supplement.c b/res/res_pjsip_pidf_digium_body_supplement.c
index 832f423..4150340 100644
--- a/res/res_pjsip_pidf_digium_body_supplement.c
+++ b/res/res_pjsip_pidf_digium_body_supplement.c
@@ -42,9 +42,11 @@
 	pj_xml_node *node;
 	char sanitized[1024];
 
+	/* The res_pjsip_exten_state module converts the user agent to lower case */
 	if (ast_strlen_zero(state_data->user_agent) ||
-	    !strstr(state_data->user_agent, "digium")) {
-		/* not a digium phone */
+	    (!strstr(state_data->user_agent, "digium") &&
+		!strstr(state_data->user_agent, "sangoma"))) {
+		/* not a Sangoma phone */
 		return 0;
 	}
 
@@ -107,7 +109,7 @@
 	return 0;
 }
 
-AST_MODULE_INFO(ASTERISK_GPL_KEY, AST_MODFLAG_LOAD_ORDER, "PJSIP PIDF Digium presence supplement",
+AST_MODULE_INFO(ASTERISK_GPL_KEY, AST_MODFLAG_LOAD_ORDER, "PJSIP PIDF Sangoma presence supplement",
 	.support_level = AST_MODULE_SUPPORT_CORE,
 	.load = load_module,
 	.unload = unload_module,

-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/15373
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: certified/16.8
Gerrit-Change-Id: Ib99362b24b91d3cbe888d8b2fce3fad5515d9482
Gerrit-Change-Number: 15373
Gerrit-PatchSet: 1
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210125/3be9cd22/attachment.html>