[Asterisk-code-review] main/frame: Add missing control frame names to ast_frame_subclass2str (asterisk[16])

Sean Bright asteriskteam at digium.com
Mon Jan 25 10:41:17 CST 2021


Sean Bright has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/15339 )

Change subject: main/frame: Add missing control frame names to ast_frame_subclass2str
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/c/asterisk/+/15339/2/main/frame.c 
File main/frame.c:

https://gerrit.asterisk.org/c/asterisk/+/15339/2/main/frame.c@463 
PS2, Line 463: 			ast_copy_string(subclass, "Video update", slen);
Capitalize 'update' to be consistent with the others (e.g. Key Radio, Take Off Hook, etc.)



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/15339
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I1724f2f4d1b064b25a5c93a7da0cb03be5143935
Gerrit-Change-Number: 15339
Gerrit-PatchSet: 2
Gerrit-Owner: Ivan Poddubny <ivan.poddubny at gmail.com>
Gerrit-Reviewer: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-Comment-Date: Mon, 25 Jan 2021 16:41:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210125/cc076cc3/attachment-0001.html>


More information about the asterisk-code-review mailing list