[Asterisk-code-review] res_musiconhold: Add support of various URL-schemes by MoH. (asterisk[master])

[Sean Bright]

Sean Bright has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/15381 )

Change subject: res_musiconhold: Add support of various URL-schemes by MoH.
......................................................................


Patch Set 1: Code-Review-1

(2 comments)

https://gerrit.asterisk.org/c/asterisk/+/15381/1/res/res_musiconhold.c 
File res/res_musiconhold.c:

https://gerrit.asterisk.org/c/asterisk/+/15381/1/res/res_musiconhold.c@1121 
PS1, Line 1121: 			if (ast_begins_with(var->value, "/") || strstr(var->value, "://") != NULL) {
You can drop the explicit NULL comparison here:

 ... || strstr(var->value, "://")) {


https://gerrit.asterisk.org/c/asterisk/+/15381/1/res/res_musiconhold.c@1147 
PS1, Line 1147: 				ast_log(LOG_ERROR, "Playlist entries must be an HTTP(S) URL or absolute path, '%s' provided.\n", var->value);
Because this will no longer be limited to HTTP(S) this message should be updated to make more sense.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/15381
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: If0ea8697587353dce358a70035d82649fd4632b6
Gerrit-Change-Number: 15381
Gerrit-PatchSet: 1
Gerrit-Owner: Boris P. Korzun <drtr0jan at yandex.ru>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-Comment-Date: Mon, 25 Jan 2021 15:09:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210125/78186022/attachment.html>